Replace bcoin with bitcoinjs-lib for deposit-sweep #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaszslabon
force-pushed
the
deposit-sweep-use-bitcoinjs-lib
branch
from
035e9c4 to
8f5a718
Compare
tomaszslabon
force-pushed
the
deposit-sweep-use-bitcoinjs-lib
branch
from
8f5a718 to
f0c5dc2
Compare
tomaszslabon
force-pushed
the
deposit-sweep-use-bitcoinjs-lib
branch
from
7d3f496 to
e609cee
Compare
tomaszslabon
requested review from
lukasz-zimnoch and
michalsmiarowski
and removed request for
lukasz-zimnoch
tomaszslabon
force-pushed
the
install-bitcoinjs-lib
branch
from
bbfa3c6 to
e019dd1
Compare
tomaszslabon
force-pushed
the
deposit-sweep-use-bitcoinjs-lib
branch
from
6833051 to
dcf7314
Compare
tomaszslabon
force-pushed
the
deposit-sweep-use-bitcoinjs-lib
branch
from
e243f0f to
da9856a
Compare
lukasz-zimnoch
requested changes
Sep 27, 2023
tomaszslabon
force-pushed
the
deposit-sweep-use-bitcoinjs-lib
branch
from
ddc92db to
770032c
Compare
tomaszslabon
force-pushed
the
deposit-sweep-use-bitcoinjs-lib
branch
from
d224d88 to
b0eac23
Compare
lukasz-zimnoch
approved these changes
Sep 28, 2023
lukasz-zimnoch
added a commit
that referenced
this pull request
Oct 9, 2023
Here we pull changes from #700
lukasz-zimnoch
added a commit
that referenced
this pull request
Oct 10, 2023
Here we pull changes from #700
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #696.
Refs: #695.
This PR replaces the
bcoinlibrary withbitcoinjs-libfor deposit sweep transactions.The
bcoinlibrary was removed fromdeposit-sweep.ts.After this update, deposit sweep generally works in the same way as before.
The only difference is that transaction inputs are always added in the same order:
Before this change the inputs could be rearranged by the
bcoinlibrary.